AOT compatibility #621
Merged
AOT compatibility #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mburumaxwell
force-pushed
the
IsAotCompatible
branch
from
f927364 to
7e13a22
Compare
This replaces `IsTrimmable` with `IsAotCompatible` which contains better analyzers. As a result, the deserialize and consume logic has been updated to handle specifics such as generics that cannot be inferred in AOT. Initial support for trimming in #564 did not have support for JSON serializer. Using the slim event bus meant you needed to create your own serializer and register it as a default. With this PR, the `DefaultJsonEventSerializer` support the use of a `JsonSerializerContext` where each event has been declared as `EventEnvelope<TEvent>`. Consequently, registration of consumers requires explicit events as shown in the sample
mburumaxwell
force-pushed
the
IsAotCompatible
branch
from
7e13a22 to
1d1bfff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces
IsTrimmablewithIsAotCompatiblewhich contains better analyzers. As a result, the deserialize and consume logic has been updated to handle specifics such as generics that cannot be inferred in AOT.Initial support for trimming in #564 did not have support for JSON serializer. Using the slim event bus meant you needed to create your own serialzier and register it as a default. With this PR, the
DefaultJsonEventSerializersupport the use of aJsonSerializerContextwhere each event has been declared asEventEnvelope<TEvent>A sample that supports AOT has been added to show how to work with it. This also helps during test and development.