-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for security-only updates using Dependabot CLI #1394
Merged
mburumaxwell
merged 44 commits into
tinglesoftware:main
from
rhyskoedijk:feature/security-only-updates
Dec 9, 2024
Merged
Support for security-only updates using Dependabot CLI #1394
mburumaxwell
merged 44 commits into
tinglesoftware:main
from
rhyskoedijk:feature/security-only-updates
Dec 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fix-pull-request-id-undefined
…fix-pull-request-id-undefined
This reverts commit 9561273.
…security-only-updates
rhyskoedijk
changed the title
Add support for security-only updates in TaskV2
Support for security-only updates in TaskV2
Oct 14, 2024
…ependencies during a security-only update
…security-only-updates
rhyskoedijk
changed the title
Support for security-only updates in TaskV2
Support for security-only updates using Dependabot CLI
Dec 2, 2024
@mburumaxwell this is ready now if you don't have any objections. It's not perfect due to the workarounds I've had to do (mentioned above), but it at least works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1490
This change adds support for "security-only" updates in TaskV2 using Dependabot CLI.
Security-only updates (i.e.
open-pull-requests-limit: 0
) incur a slight performance overhead due to limitations in Dependabot CLI (#360). To work around this, vulnerable dependencies will first be discovered using an "ignore everything" update job; After which, security advisories for the discovered dependencies will be checked against the GitHub Advisory Database before finally performing the requested security-only update job. It might be possible to optimise this process in the future, but for now this is the best that I can come up with.High-level sequence diagram of security-only update process
Example update scenario
Example of security advisories being fetched from GHSA:
Example of security advisories being passed in to
job.yml
:Example of Dependabot analysing next safe version:
Example of PR creation: