refactor: Change from useEffect to useSyncExternalStore #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@minsgy is attempting to deploy a commit to the analytics-billing-vtest314 Team on Vercel. A member of the Team first needs to authorize it. |
minsgy
changed the title
|
Thanks for this! I will merge this as part of the next major release, since it requires React 18+. |
Required for `useSyncExternalStore`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as-is
The original code used
useEffectto register thevisibilitychangeevent on the document and update the state based on the document's visibility state in the event handler.to-be
The updated code uses
useSyncExternalStoreto synchronize the external state changes.useSyncExternalStoreprovides asubscribefunction to detect changes in the external state and a function to retrieve the current state. This allows for efficient observation of the document's visibility state changes and updating the state accordingly.These changes have improved the readability and efficiency of the code.