Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "stack overflow" issue when processing very large input buffers #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix "stack overflow" issue when processing very large input buffers #1

wants to merge 2 commits into from

Conversation

anszom
Copy link

@anszom anszom commented Sep 13, 2023

I've encountered this problem while stress-testing a server by feeding it an endless stream of "{}\n"

@anszom
fix tests
e759809 
npm test failed on node v16 / v18, requiring some minor changes.
Additionally, streams now stop automatically after an error is emitted,
so a test case that addressed a scenario happening after an error was
removed.
@anszom
Avoid recursion in _parseDocs
2b387d1 
Otherwise the JS runtime would run out of stack space when processing
large input buffers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@anszom