-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to snoop commands to control spawning separate process vs eval'ing in existing process #252
Open
NHDaly
wants to merge
8
commits into
master
Choose a base branch
from
nhd-snoop-all
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+153
−34
Open
Add option to snoop commands to control spawning separate process vs eval'ing in existing process #252
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
74371aa
Add `pspawn=true` to `@snoopl` to allow staying in the same process!
NHDaly 25c2d6e
Add `@snoop_all` to run snoopi, snoopc, snoopl
NHDaly ecdb272
Add `pspawn=` option to snoopc; add snoopc to snoop_all
NHDaly 50c030a
Add basic test for snoop_all.
NHDaly e1795a1
Change `@snoop_all` to generate the output filenames
NHDaly 24c8c47
Add docstring to snoop_all
NHDaly 995ffd2
Simplify process spawning code
NHDaly c06d84e
Add documentation links & example to docstring
NHDaly File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
# TODO: Add `@snoopc` into the mix | ||
macro snoop_all(csv_f, yaml_f, commands) | ||
esc(quote | ||
v = @snoopi_deep begin | ||
@snoopl pspawn=false $csv_f $yaml_f begin | ||
$commands | ||
end | ||
end; | ||
v | ||
end) | ||
end |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we just include this macro into
SnoopCompileCore/src/snoopl.jl
? It's the same condition for including it that we use for@snoopl
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, good idea. I've just moved it into the same if-block. I guess it doesn't necessarily belong in
snoopl.jl
because it will snoop all three types of compilation, which is why I put it in its own file.Can you have another look and let me know if this looks okay? :)