expose build args, format file, update deps and fix diggest upload #44
Conversation
sebastianwebber
force-pushed
the
sebastian/add-missing-arch-on-builds
branch
2 times, most recently
from
e4ee401
to
e832e69
Compare
sebastianwebber
force-pushed
the
sebastian/add-missing-arch-on-builds
branch
3 times, most recently
from
c6d1e39
to
57c1655
Compare
.github/workflows/build.yaml
Outdated
| with: | ||
| aws-access-key-id: ${{ secrets.AWS_ACCESS_KEY_ID }} | ||
| aws-secret-access-key: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | ||
| aws-region: ${{ inputs.region }} | ||
|
|
There was a problem hiding this comment.
nit: I add the newlines for a visual separation between steps :)
| - name: Upload digest | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: digests-${{ env.PLATFORM_DASH_PAIR }} | ||
| name: digests-${{ inputs.docker_target }}-${{ env.IMAGE_DIGEST }} |
There was a problem hiding this comment.
The docker target isn't a required argument- what happens if it's not set? Just digests--<digest>? I think the platform is pretty important to include- I'm using depending on it as digests-{{ matrix.platform }}-* in the download steps elsewhere so it can properly attribute the arch. I'd suggest adding something instead of replacing the platform env?
There was a problem hiding this comment.
in this case it will generate a file like digest--2369058236gjgfhsdjgsjdtgyu23u852365
There was a problem hiding this comment.
let me update the problem in the read me, when using the current strategy twice (parliament and owl) it fails because the file already exists.
There was a problem hiding this comment.
Yup, that would totally happen! The IMAGE_DIGEST should stop that for sure.
sebastianwebber
force-pushed
the
sebastian/add-missing-arch-on-builds
branch
2 times, most recently
from
859f9a6
to
1738166
Compare
this commit updates the yaml file, updating github action versions of the dependencies, exposing the GOARCH, BPF_ARCH, and GOOS environment variables in the docker build with build args, and fix the diggest upload filename that was failing when this action was called more than once. Signed-off-by: Sebastian Webber <[email protected]>
sebastianwebber
force-pushed
the
sebastian/add-missing-arch-on-builds
branch
from
1738166
to
13ca8ec
Compare
sebastianwebber
changed the title
when using the build workflow for multi-arch images multiple times, it fails because the file already exists.
Related: https://github.com/timescale/savannah-owl/pull/346