Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: monolith to dedicated features #177

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Conversation

y9vad9
Copy link
Member

@y9vad9 y9vad9 commented Feb 11, 2024

Is it breaking change?

For public API – No, but it's a big internal change.

Have you synchronized changes with other repositories?

No need in it.

Explain why this change is important

Explain the importance of the change.

Specify linked issues or discussions

closes #176

Additional information

In addition, I rewrote FSM from scratch giving ability to declare it as DSL avoiding logic in the entities.

…pters and tests for all necessary layers), without tests, deps and adapters – users, timers; added ':core' module with all 'core' types that applicable for every feature.
@y9vad9 y9vad9 self-assigned this Feb 11, 2024
Copy link
Member

@sliderzxc sliderzxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know is the logic correct, but code is correct!

@y9vad9 y9vad9 marked this pull request as ready for review February 19, 2024 12:01
@y9vad9 y9vad9 merged commit ae7793e into master Feb 19, 2024
1 check passed
@y9vad9 y9vad9 deleted the refactor-to-features branch February 19, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor FSM to avoid logic in the entities
2 participants