Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: RSocket API with rsproto #171

Merged
merged 5 commits into from
Dec 13, 2023
Merged

feat: RSocket API with rsproto #171

merged 5 commits into from
Dec 13, 2023

Conversation

y9vad9
Copy link
Member

@y9vad9 y9vad9 commented Dec 13, 2023

Is it breaking change?
The following changes are applied:

  • rsocket-api is refactored, API is now exposed as RPCs.
  • grpc-api is removed.

Have you synchronized changes with other repositories?
Not yet for sdk.

@y9vad9 y9vad9 added feature New feature or request refactor labels Dec 13, 2023
@y9vad9 y9vad9 added this to the 1.0 milestone Dec 13, 2023
@y9vad9 y9vad9 self-assigned this Dec 13, 2023
@y9vad9 y9vad9 merged commit db02fc4 into master Dec 13, 2023
1 check passed
@y9vad9 y9vad9 deleted the rsproto-impl branch December 13, 2023 16:39
Copy link
Member

@sliderzxc sliderzxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fun authorized in infrastructure/rsocket-api/src/main/kotlin/io/timemates/api/rsocket/internal/AuthorizationContext.kt does not have an implementation there is just TODO() correct it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request refactor
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

3 participants