Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rand to 0.8.0 #299

Closed
wants to merge 1 commit into from
Closed

Bump rand to 0.8.0 #299

wants to merge 1 commit into from

Conversation

dmit
Copy link
Contributor

@dmit dmit commented Dec 19, 2020

Closes #298.

@jhpratt
Copy link
Member

jhpratt commented Dec 19, 2020

Going to hold off on this until BurntSushi/quickcheck#264 is merged. I'd prefer to have two versions of the same crate in dependency tree for obvious reasons.

In the future, feel free to just create a pull request for something like this! Issues are only really necessary for larger features.

@jhpratt jhpratt added the C-keep-open Category: should not be closed due to inactivity label Dec 26, 2020
@jhpratt
Copy link
Member

jhpratt commented Dec 28, 2020

Looks like quickcheck has updated to rand 0.8, and is nearing a 1.0 release. When that happens, we'll be all set! I just need to clarify the MSRV policy, as quickcheck requires 1.46 now (time won't bump MSRV to that until mid-Q1 next year).

@dmit
Copy link
Contributor Author

dmit commented Dec 28, 2020

@jhpratt Let me know if you want me to update this PR after the next quickcheck release lands, or if you want this closed and to follow a more MSRV-friendly approach.

@jhpratt
Copy link
Member

jhpratt commented Dec 28, 2020

Feel free to update it on the next quickcheck release. The MSRV policy will be clarified that any feature enabling an external crate isn't included (unless said feature is enabled by default, which isn't the case anywhere).

@jhpratt jhpratt force-pushed the main branch 2 times, most recently from fbf133d to ec4057d Compare December 28, 2020 10:21
@jhpratt
Copy link
Member

jhpratt commented Jan 9, 2021

@dmit Would you like to perform the changes, or would you rather I do it? I don't particularly care either way.

@jhpratt jhpratt mentioned this pull request Jan 9, 2021
@jhpratt
Copy link
Member

jhpratt commented Jan 11, 2021

Closing in favor of #304.

@jhpratt jhpratt closed this Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-keep-open Category: should not be closed due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrading to rand 0.8
2 participants