Skip to content

Commit

Permalink
nit
Browse files Browse the repository at this point in the history
Signed-off-by: Derek Brown <[email protected]>
  • Loading branch information
Derek Brown authored and Derek Brown committed Dec 23, 2024
1 parent ee88e08 commit f6502ca
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion pkg/cluster/admin_kind.go
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ func (a *kindAdmin) kindClusterConfig(desired *api.Cluster, registry *api.Regist
// Parse the endpoint
parsedEndpoint, err := url.Parse(reg.Endpoint)
if err != nil {
klog.Warningf("Failed to parse registry URL %s: %v", reg.Endpoint)
klog.Warningf("Failed to parse registry URL %s: %v", reg.Endpoint, err)
continue
}

Expand Down
4 changes: 2 additions & 2 deletions pkg/cluster/admin_kind_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ func TestKindClusterConfigWithPullThroughRegistries(t *testing.T) {
RegistryAuths: []api.RegistryAuth{
{
Host: "example.com",
Endpoint: "example.com:5000",
Endpoint: "http://example.com:5000",
Username: "user",
Password: "pass",
},
Expand All @@ -110,7 +110,7 @@ func TestKindClusterConfigWithPullThroughRegistries(t *testing.T) {
expectedMirror := `[plugins."io.containerd.grpc.v1.cri".registry.mirrors."example.com"]
endpoint = ["http://example.com:5000"]
`
expectedAuth := `[plugins."io.containerd.grpc.v1.cri".registry.configs."example.com".auth]
expectedAuth := `[plugins."io.containerd.grpc.v1.cri".registry.configs."example.com:5000".auth]
username = "user"
password = "pass"
`
Expand Down

0 comments on commit f6502ca

Please sign in to comment.