Merge pull request #5 from tilde-nlp/fix/option_validation

Add option validation
tilde-nlp · Aug 21, 2024 · c515b3c · c515b3c
2 parents e25f329 + 7f7d74e
commit c515b3c
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 3 deletions.
diff --git a/Tilde.Translation/AppInfo.cs b/Tilde.Translation/AppInfo.cs
@@ -17,12 +17,12 @@ public class AppInfo
         /// <summary>
         /// Application name where this library will be used
         /// </summary>
-        public string? AppName { get; set; }
+        public string AppName { get; set; }
 
         /// <summary>
         /// Version of application where this library will be used
         /// </summary>
-        public string? AppVersion { get; set; }
+        public string AppVersion { get; set; }
 
         /// <summary>
         /// Origin which requests machine translation

diff --git a/Tilde.Translation/Tilde.Translation.csproj b/Tilde.Translation/Tilde.Translation.csproj
@@ -5,7 +5,7 @@
     <Description>Official dotnet library for the Tilde translation API</Description>
     <PackageTags>tilde;translation;translator;translate;api;i18n;language;</PackageTags>
     <!-- Change only <Version> tag, other tags will be autogenerated on build -->
-    <Version>1.0.10.0</Version>
+    <Version>1.0.11.0</Version>
     <TargetFrameworks>net6.0;net7.0;net8.0;netstandard2.0;netstandard2.1;net462;net472;net48;net481;</TargetFrameworks>
     <LangVersion>latest</LangVersion>
     <ImplicitUsings>enable</ImplicitUsings>

diff --git a/Tilde.Translation/Translator.cs b/Tilde.Translation/Translator.cs
@@ -39,6 +39,19 @@ public Translator(string apiKey, TranslatorOptions? options = null)
         {
             options ??= new TranslatorOptions();
 
+            if (options.AppInfo != null)
+            {
+                if (string.IsNullOrWhiteSpace(options.AppInfo.AppVersion))
+                {
+                    throw new ArgumentNullException($"{nameof(options)}.{nameof(options.AppInfo)}.{nameof(options.AppInfo.AppVersion)}");
+                }
+
+                if (string.IsNullOrWhiteSpace(options.AppInfo.AppName))
+                {
+                    throw new ArgumentNullException($"{nameof(options)}.{nameof(options.AppInfo)}.{nameof(options.AppInfo.AppName)}");
+                }
+            }
+
             if (apiKey == null)
             {
                 throw new ArgumentNullException(nameof(apiKey));