Upgrade RocksDB #319
Merged
Upgrade RocksDB #319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v01dstar
force-pushed
the
upgrade-rocksdb
branch
from
0e45324 to
68960f0
Compare
v01dstar
force-pushed
the
upgrade-rocksdb
branch
3 times, most recently
from
d0a89ec to
6b8c4ed
Compare
|
/run-all-tests |
v01dstar
force-pushed
the
upgrade-rocksdb
branch
from
6b8c4ed to
15866a4
Compare
Signed-off-by: Yang Zhang <[email protected]>
v01dstar
force-pushed
the
upgrade-rocksdb
branch
from
15866a4 to
ade72c6
Compare
|
/run-all-tests |
Connor1996
approved these changes
Oct 8, 2024
|
/retest |
LykxSassinator
approved these changes
Oct 8, 2024
|
/run-all-tests |
3 similar comments
|
/run-all-tests |
|
/run-all-tests |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cachehas been moved to a different place with API changes. Nowcache_->Insert()requires akBlobFileReaderCacheItemHelperinstead of a delete function callback solely.kTypeTitanColumnFamilyBlobIndexandkTypeTitanBlobIndexto separate from RocksDB's native blob implementation'skTypeColumnFamilyBlobIndexandkTypeBlobIndex. Writing to RocksDB now usesPutTitanBlobIndex()instead ofPutBlobIndex(). see Titan followup changes rocksdb#390ReadOptions, so Titan no longer need to propagatefor_compactionto lower level readers to indicates its low priority for IO.seqnoin CompactionFilter. Since it is no longer used in TiKV