Revert bloom filter name extension #794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yang Zhang <[email protected]>
v01dstar
force-pushed
the
fix-bloom-filter
branch
from
76b17a6 to
014fbcf
Compare
overvenus
approved these changes
Jul 30, 2024
v01dstar
added a commit
to v01dstar/rust-rocksdb
that referenced
this pull request
Aug 5, 2024
Signed-off-by: Yang Zhang <[email protected]>
Merged
v01dstar
added a commit
to v01dstar/rust-rocksdb
that referenced
this pull request
Aug 5, 2024
Signed-off-by: Yang Zhang <[email protected]>
Connor1996
pushed a commit
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply RocksDB fix tikv/rocksdb#365, which uses prefix match instead of exact match for determining whether a bloom filter is compatible or not.
Also, revert the change that added the filter type as suffix, since it is unnecessary (all internal filters can be used interchangeably), and is causing compatibility issues (tikv/tikv#17272), i.e. SSTs created before 7.1 with filter meta block named using
rocksdb.BuiltinBloomFilterare no longer recognized by newer versions of TiKV.We will probably have to maintain the customized change "prefix match" for a while, to make sure impacted versions are migrated smoothly.