Revert "Snapshot release triggered compaction without multiple tombstones" #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… multiple tombstones (facebook#8357)" (facebook#8410)" (facebook#8438)" This reverts commit f89423a. Signed-off-by: Yang Zhang <[email protected]>
ti-chi-bot
bot
added
dco-signoff: yes
overvenus
approved these changes
Oct 29, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
LykxSassinator
approved these changes
Oct 29, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LykxSassinator, overvenus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "Revert " Revert "Snapshot release triggered compaction without multiple tombstones (facebook#8357)" (facebook#8410)" (facebook#8438)"
We observed:
We also tried the new option introduced in facebook#11701 for delaying such compactions, but it did not resolve the issue.
So, we are reverting the commit.
This reverts commit f89423a.
Maintainer's node:
We need to cherry-pick this in future RocksDB upgrades, until new improvements are proposed in upstream.