Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sanitize 8.10.tikv branch #372

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Sanitize 8.10.tikv branch #372

merged 2 commits into from
Sep 20, 2024

Conversation

v01dstar
Copy link

@v01dstar v01dstar commented Sep 18, 2024

  1. Update sanity check yml
  2. Disable the PurgeInfoLog test, since it fails with current tikv/rocksdb CI setup.
    This test fails if it run as ./db_test, since previous test cases create
    a dir under dbname causing the assertion in line 2722 to fail. It passes
    when run as make check -j x, since test case is executed in separate
    directory.
    TiKV CI cannot migrate to make check -j x (running each test case separately), it is now running with make all_but_some_tests (running all test cases in the same test suite in the same directory) because the sub-steps require
    python3, which is not available in TiKV CI centos7.

Signed-off-by: Yang Zhang <[email protected]>
@ti-chi-bot ti-chi-bot bot added dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 18, 2024
@v01dstar
Copy link
Author

/run-all-tests

@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 19, 2024
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 19, 2024
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 19, 2024
Signed-off-by: Yang Zhang <[email protected]>
@v01dstar
Copy link
Author

/run-all-tests

Copy link

ti-chi-bot bot commented Sep 20, 2024

@LykxSassinator: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Sep 20, 2024

@glorv: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Sep 20, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: glorv, LykxSassinator

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@glorv glorv merged commit 49a8021 into tikv:8.10.tikv Sep 20, 2024
4 of 5 checks passed
@v01dstar v01dstar deleted the sanitize branch September 20, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes Indicates the PR's author has signed the dco. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants