Add copy constructor to ColumnFamilyHandleImpl #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yang Zhang <[email protected]>
Signed-off-by: Yang Zhang <[email protected]>
tonyxuqqi
approved these changes
Dec 28, 2023
Connor1996
reviewed
Dec 30, 2023
| @@ -50,6 +50,14 @@ ColumnFamilyHandleImpl::ColumnFamilyHandleImpl( | |||
| } | |||
| } | |||
|
|
|||
| ColumnFamilyHandleImpl::ColumnFamilyHandleImpl( | |||
| const ColumnFamilyHandleImpl& other) | |||
Signed-off-by: Yang Zhang <[email protected]>
Signed-off-by: Yang Zhang <[email protected]>
tonyxuqqi
reviewed
Jan 3, 2024
db/column_family.cc
Outdated
| @@ -50,6 +50,15 @@ ColumnFamilyHandleImpl::ColumnFamilyHandleImpl( | |||
| } | |||
| } | |||
|
|
|||
| ColumnFamilyHandleImpl::ColumnFamilyHandleImpl(ColumnFamilyHandleImpl&& other) { | |||
| other.cfd_ = cfd_; | |||
There was a problem hiding this comment.
so that means the new ColumnFamilyHandleImpl instance will not have the valid information, but the other will be overwritten by the default values of ColumnFamilyHandleImpl?
I would imagine other will be empty and it's moved to this instance.
There was a problem hiding this comment.
You are right, I didn't pay attention to copilot generated code.
Signed-off-by: Yang Zhang <[email protected]>
v01dstar
changed the title
Signed-off-by: Yang Zhang <[email protected]>
v01dstar
changed the title
Signed-off-by: Yang Zhang <[email protected]>
Signed-off-by: Yang Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref tikv/titan#294
This is needed by tikv/titan#298.
In that PR, we need to create Titan's own
ColumnFamiliyHandleinstances. To avoid memory leak, we need to deleteColumnFamilyHandleImplinstances created by RocksDB itself.