Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] RFC: keyspace level GC #113

Open
wants to merge 54 commits into
base: master
Choose a base branch
from
Open

Conversation

ystaticy
Copy link

No description provided.

text/0113-keyspace-level-gc.md Outdated Show resolved Hide resolved
text/0113-keyspace-level-gc.md Outdated Show resolved Hide resolved
Copy link
Member

@Connor1996 Connor1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@pingyu pingyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do other services, e.g, BR (especial global BR) & CDC, adapt to this feature ?

text/0113-keyspace-level-gc.md Outdated Show resolved Hide resolved
text/0113-keyspace-level-gc.md Outdated Show resolved Hide resolved
text/0113-keyspace-level-gc.md Outdated Show resolved Hide resolved
text/0113-keyspace-level-gc.md Outdated Show resolved Hide resolved
text/0113-keyspace-level-gc.md Outdated Show resolved Hide resolved
text/0113-keyspace-level-gc.md Outdated Show resolved Hide resolved
text/0113-keyspace-level-gc.md Outdated Show resolved Hide resolved
text/0113-keyspace-level-gc.md Outdated Show resolved Hide resolved
text/0113-keyspace-level-gc.md Outdated Show resolved Hide resolved
text/0113-keyspace-level-gc.md Outdated Show resolved Hide resolved
@ystaticy
Copy link
Author

How do other services, e.g, BR (especial global BR) & CDC, adapt to this feature ?

@pingyu Other services are adapted in pingcap/tidb, mainly when importing and exporting keyspace data, and using the safe point v2 interface if keyspace level GC is enabled in the keyspace. There is no need to modify the logic of TiKV. So it is not described here.

CDC does not yet support specifying keyspaces, so this will not be changed at this time.

baiyuqing and others added 23 commits September 20, 2024 18:19
Signed-off-by: baiyuqing <[email protected]>
Signed-off-by: baiyuqing <[email protected]>
Signed-off-by: baiyuqing <[email protected]>
Signed-off-by: baiyuqing <[email protected]>
Signed-off-by: baiyuqing <[email protected]>
Signed-off-by: baiyuqing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants