Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update prost, prost-derive and prost-build to 0.12 #223

Merged
merged 3 commits into from
Sep 27, 2023
Merged

chore: Update prost, prost-derive and prost-build to 0.12 #223

merged 3 commits into from
Sep 27, 2023

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Sep 25, 2023 •
edited
Loading

Rationale:

prost has been updated and it would be nice for downstream crates (like IOx) to not have multiple versions of prost

Changes:

  • chore: Update prost, prost-derive and prost-build to 0.12

@alamb
Copy link
Contributor Author

alamb commented Sep 25, 2023

cc @YangKeao @Xuanwo

YangKeao
YangKeao approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Xuanwo
Xuanwo approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@YangKeao
Copy link
Member

YangKeao commented Sep 26, 2023 •
edited
Loading

CI failed because we need to bump the MSRV. See: #225

@YangKeao
Copy link
Member

Please rebase the master. Then it should pass the CI 🍻

@alamb alamb force-pushed the alamb/update_prost branch from 342d4fb to af8a5f0 Compare September 26, 2023 11:20
@alamb
Copy link
Contributor Author

alamb commented Sep 26, 2023

Please rebase the master. Then it should pass the CI 🍻

Done!

@alamb
Copy link
Contributor Author

alamb commented Sep 26, 2023

I believe #224 will need to be merged first to get the CI to pass cleanly

@alamb alamb force-pushed the alamb/update_prost branch from af8a5f0 to 90b042f Compare September 26, 2023 18:46
@alamb
fix: Update cargo.lock
0cfbb89 
Signed-off-by: Andrew Lamb <[email protected]>
@alamb alamb force-pushed the alamb/update_prost branch from af92f51 to 0cfbb89 Compare September 26, 2023 19:14
@sticnarf
Copy link
Contributor

Can you help run rm proto/perftools.profiles.rs && cargo check --features prost-codec to update the pre-compiled prost source? Then, CI will be happy.

@YangKeao YangKeao merged commit ea54318 into tikv:master Sep 27, 2023
23 checks passed
@alamb
Copy link
Contributor Author

alamb commented Sep 27, 2023

🎉 -- thank you so much for all the help @sticnarf and @YangKeao

@alamb alamb deleted the alamb/update_prost branch September 27, 2023 11:03
@YangKeao YangKeao mentioned this pull request Sep 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sticnarf sticnarf sticnarf approved these changes

@Xuanwo Xuanwo Xuanwo approved these changes

@YangKeao YangKeao YangKeao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alamb @YangKeao @sticnarf @Xuanwo