validate whether addr is null before constructing slice #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YangKeao
force-pushed
the
fix-null-slice-construction
branch
from
d8d85b9 to
83aff0f
Compare
Right... Though there is a If we enable |
|
I have no idea about the CI failures due to linking errors... |
YangKeao
force-pushed
the
fix-null-slice-construction
branch
2 times, most recently
from
de55da0 to
851d881
Compare
Signed-off-by: YangKeao <[email protected]>
YangKeao
force-pushed
the
fix-null-slice-construction
branch
from
851d881 to
0ee067d
Compare
|
Hey, as a data point, I just hit this and building with release did fix it. I hit this specifically because I'm a M1 user. So first adding this crate and running it crashed. I read #187 and enabled the frame pointer feature flag, nightly and added -Z build-std. Then I hit this. |
|
It has been fixed in #255. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: YangKeao [email protected]
Validate whether the address is null before trying to construct the slice. Because in debug build, the
from_raw_partswill check whether the addr is null and aligned, if not, it will panic.The embarrasing part is that this problem cannot be reproduced through test, so the current test cannot cover this situation...