pd-ctl: print warn information when set max-replica to less than 3 #8983
Conversation
Signed-off-by: lhy1024 <[email protected]>
ti-chi-bot
bot
added
release-note-none
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8983 +/- ##
==========================================
+ Coverage 74.91% 76.33% +1.42%
==========================================
Files 416 465 +49
Lines 42103 70555 +28452
==========================================
+ Hits 31543 53861 +22318
- Misses 7810 13350 +5540
- Partials 2750 3344 +594
Flags with carried forward coverage won't be shown. Click here to find out more. |
| if key == "max-replicas" { | ||
| replica, err := strconv.ParseInt(value, 10, 64) | ||
| if err == nil && replica < sc.DefaultMaxReplicas { | ||
| cmd.Println("Setting max-replica to less than 3 may be a mistake and carries high risk. Please confirm the setting.") |
There was a problem hiding this comment.
I think the original issue wants an interactive way to confirm the operation instead of just printing a message.
There was a problem hiding this comment.
After the discussion with @niubell , we will not add an interactive way in pd-ctl for now.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: okJiang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: Close #8959
What is changed and how does it work?
Check List
Tests
Release note