Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: Add API for RawKV GC #4918

Closed
wants to merge 1 commit into from
Closed

Conversation

pingyu
Copy link
Contributor

@pingyu pingyu commented May 11, 2022

Signed-off-by: pingyu [email protected]

What problem does this PR solve?

Add APIs for RawKV GC (storage part of #4866).
Issue Number: ref #4865
RFC: tikv/rfcs#90

What is changed and how does it work?

Add APIs for RawKV GC.

Check List

Tests

  • Unit test

Code changes

Side effects
No.

Related changes

Release note

Add APIs for RawKV GC.

Issue Number: tikv#4865

Signed-off-by: pingyu <[email protected]>
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 11, 2022
@ti-chi-bot ti-chi-bot requested review from disksing and nolouch May 11, 2022 02:01
@pingyu
Copy link
Contributor Author

pingyu commented May 11, 2022

/cc @nolouch @AndreMouche

@ti-chi-bot ti-chi-bot requested a review from AndreMouche May 11, 2022 02:02
@pingyu
Copy link
Contributor Author

pingyu commented May 11, 2022

/cc @nolouch @AndreMouche

PTAL, thanks~

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #4918 (0b2ec53) into master (c1ae899) will decrease coverage by 0.08%.
The diff coverage is 67.74%.

@@            Coverage Diff             @@
##           master    #4918      +/-   ##
==========================================
- Coverage   75.36%   75.28%   -0.09%     
==========================================
  Files         296      298       +2     
  Lines       29441    29514      +73     
==========================================
+ Hits        22189    22219      +30     
- Misses       5322     5348      +26     
- Partials     1930     1947      +17     
Flag Coverage Δ
unittests 75.28% <67.74%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/storage/endpoint/gc_safe_point.go 70.83% <ø> (ø)
server/storage/endpoint/gc_service_group.go 65.51% <65.51%> (ø)
server/storage/endpoint/key_path.go 100.00% <100.00%> (ø)
server/tso/local_allocator.go 64.86% <0.00%> (-13.52%) ⬇️
server/tso/allocator_manager.go 63.39% <0.00%> (-5.16%) ⬇️
pkg/dashboard/adapter/manager.go 79.31% <0.00%> (-4.39%) ⬇️
pkg/etcdutil/etcdutil.go 85.05% <0.00%> (-3.45%) ⬇️
server/schedule/checker/merge_checker.go 69.92% <0.00%> (-2.88%) ⬇️
server/api/config.go 60.64% <0.00%> (-2.72%) ⬇️
server/schedule/labeler/rules.go 87.20% <0.00%> (-2.33%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1ae899...0b2ec53. Read the comment docs.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 11, 2022
@ti-chi-bot
Copy link
Member

@pingyu: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pingyu pingyu closed this May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants