-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[to #381] Add more integration tests for Kafka sink #387
Conversation
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
/test ? |
@pingyu: The following commands are available to trigger required jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-integration-kafka-test |
/test pull-integration-kafka-test |
/test pull-integration-kafka-test |
Signed-off-by: Ping Yu <[email protected]>
/test pull-unit-test |
Signed-off-by: Ping Yu <[email protected]>
/test pull-integration-kafka-test |
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
/test pull-integration-kafka-test |
1 similar comment
/test pull-integration-kafka-test |
/retest |
4 similar comments
/retest |
/retest |
/retest |
/retest |
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
/test ? |
@pingyu: The following commands are available to trigger required jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test all |
/test pull-unit-test |
/test pull-integration-kafka-test |
/retest |
5 similar comments
/retest |
/retest |
/retest |
/retest |
/retest |
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
/test pull-integration-kafka-test |
Signed-off-by: Ping Yu <[email protected]>
/test pull-integration-kafka-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
Issue Number: ref #381
Problem Description: TBD
What is changed and how does it work?
flow_control
case for Kafka sink. Address possible memory leak later. Ref cdc,tests: integration testflow_control
case is flaky #383.Code changes
Check List for Tests
This PR has been tested by at least one of the following methods:
Side effects
Related changes
To reviewers
Please follow these principles to check this pull requests:
(The above text mainly refers to TiDB Development Guide. It's also highly recommended to read about Writing code review comments)