Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[close #381] Support Kafka sink #380

Merged
merged 14 commits into from
Jan 5, 2024
Merged

[close #381] Support Kafka sink #380

merged 14 commits into from
Jan 5, 2024

Conversation

pingyu
Copy link
Collaborator

@pingyu pingyu commented Dec 31, 2023

What problem does this PR solve?

Issue Number: close #381

Problem Description: cdc: Support Kafka sink

What is changed and how does it work?

  • Add kafka://xxx sink.

Code changes

  • Has exported function/method change

Check List for Tests

This PR has been tested by at least one of the following methods:

Side effects

  • Increased code complexity, WHY: add Kafka sink

Related changes

  • Need to update the documentation
  • Need to be included in the release note

To reviewers

Please follow these principles to check this pull requests:

  • Concentration. One pull request should only do one thing. No matter how small it is, the change does exactly one thing and gets it right. Don't mix other changes into it.
  • Tests. A pull request should be test covered, whether the tests are unit tests, integration tests, or end-to-end tests. Tests should be sufficient, correct and don't slow down the CI pipeline largely.
  • Functionality. The pull request should implement what the author intends to do and fit well in the existing code base, resolve a real problem for TiDB/TiKV users. To get the author's intention and the pull request design, you could follow the discussions in the corresponding GitHub issue or internal.tidb.io topic.
  • Style. Code in the pull request should follow common programming style. (For Go, we have style checkers in CI). However, sometimes the existing code is inconsistent with the style guide, you should maintain consistency with the existing code or file a new issue to fix the existing code style first.
  • Documentation. If a pull request changes how users build, test, interact with, or release code, you must check whether it also updates the related documentation such as READMEs and any generated reference docs. Similarly, if a pull request deletes or deprecates code, you must check whether or not the corresponding documentation should also be deleted.
  • Performance. If you find the pull request may affect performance, you could ask the author to provide a benchmark result.

(The above text mainly refers to TiDB Development Guide. It's also highly recommended to read about Writing code review comments)

Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
@pingyu pingyu changed the title [close #] Support Kafka sink [close #381] Support Kafka sink Dec 31, 2023
@pingyu
Copy link
Collaborator Author

pingyu commented Jan 1, 2024

/test pull-integration-test
/test pull-unit-test

pingyu added 4 commits January 1, 2024 17:28
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
@pingyu
Copy link
Collaborator Author

pingyu commented Jan 2, 2024

/test pull-integration-test
/test pull-unit-test

@pingyu
Copy link
Collaborator Author

pingyu commented Jan 2, 2024

/test ?

@pingyu pingyu marked this pull request as ready for review January 2, 2024 01:11
@pingyu pingyu changed the title [close #381] Support Kafka sink [close #381] WIP: Support Kafka sink Jan 2, 2024
@pingyu
Copy link
Collaborator Author

pingyu commented Jan 2, 2024

/test ?

Copy link

ti-chi-bot bot commented Jan 2, 2024

@pingyu: The following commands are available to trigger required jobs:

  • /test pull-integration-test
  • /test pull-unit-test

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

ti-chi-bot bot commented Jan 2, 2024

@pingyu: The following commands are available to trigger required jobs:

  • /test pull-integration-test
  • /test pull-unit-test

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@purelind
Copy link

purelind commented Jan 2, 2024

/test ?

Copy link

ti-chi-bot bot commented Jan 2, 2024

@purelind: The following commands are available to trigger required jobs:

  • /test pull-integration-test
  • /test pull-unit-test

Use /test all to run all jobs.

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pingyu
Copy link
Collaborator Author

pingyu commented Jan 3, 2024

/test pull-integration-test

Signed-off-by: Ping Yu <[email protected]>
@pingyu
Copy link
Collaborator Author

pingyu commented Jan 3, 2024

/test pull-integration-test

@pingyu pingyu changed the title [close #381] WIP: Support Kafka sink [close #381] Support Kafka sink Jan 3, 2024
@pingyu pingyu requested a review from zeminzhou January 3, 2024 07:53
@pingyu
Copy link
Collaborator Author

pingyu commented Jan 3, 2024

/test pull-integration-test

@pingyu pingyu merged commit 99b7b74 into tikv:main Jan 5, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cdc: Support Kafka sink
3 participants