Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[to #323] *: Remove tidb dependency #367

Merged
merged 3 commits into from
Nov 20, 2023
Merged

Conversation

pingyu
Copy link
Collaborator

@pingyu pingyu commented Nov 19, 2023

What problem does this PR solve?

Issue Number: close #323

Problem Description: Remove dependency of "github.com/pingcap/tidb"

What is changed and how does it work?

Code changes

Check List for Tests

This PR has been tested by at least one of the following methods:

  • Unit test
  • Integration test

Side effects

  • No side effects

Related changes

  • No related changes

To reviewers

Please follow these principles to check this pull requests:

  • Concentration. One pull request should only do one thing. No matter how small it is, the change does exactly one thing and gets it right. Don't mix other changes into it.
  • Tests. A pull request should be test covered, whether the tests are unit tests, integration tests, or end-to-end tests. Tests should be sufficient, correct and don't slow down the CI pipeline largely.
  • Functionality. The pull request should implement what the author intends to do and fit well in the existing code base, resolve a real problem for TiDB/TiKV users. To get the author's intention and the pull request design, you could follow the discussions in the corresponding GitHub issue or internal.tidb.io topic.
  • Style. Code in the pull request should follow common programming style. (For Go, we have style checkers in CI). However, sometimes the existing code is inconsistent with the style guide, you should maintain consistency with the existing code or file a new issue to fix the existing code style first.
  • Documentation. If a pull request changes how users build, test, interact with, or release code, you must check whether it also updates the related documentation such as READMEs and any generated reference docs. Similarly, if a pull request deletes or deprecates code, you must check whether or not the corresponding documentation should also be deleted.
  • Performance. If you find the pull request may affect performance, you could ask the author to provide a benchmark result.

(The above text mainly refers to TiDB Development Guide. It's also highly recommended to read about Writing code review comments)

Signed-off-by: Ping Yu <[email protected]>
Signed-off-by: Ping Yu <[email protected]>
Copy link

codecov bot commented Nov 19, 2023

Codecov Report

Merging #367 (e640161) into main (0837ce5) will increase coverage by 0.5057%.
The diff coverage is 74.0740%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##               main       #367        +/-   ##
================================================
+ Coverage   61.0955%   61.6012%   +0.5057%     
================================================
  Files           240        241         +1     
  Lines         20283      20222        -61     
================================================
+ Hits          12392      12457        +65     
+ Misses         6771       6642       -129     
- Partials       1120       1123         +3     
Flag Coverage Δ *Carryforward flag
br 60.5749% <ø> (ø) Carriedforward from 73c8391
cdc 62.0802% <74.0740%> (+0.7428%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files Coverage Δ
cdc/cdc/kv/testing.go 100.0000% <ø> (+98.7577%) ⬆️
cdc/cdc/puller/puller.go 82.4000% <ø> (+1.1500%) ⬆️
cdc/cdc/server.go 35.1851% <ø> (-0.8338%) ⬇️
cdc/cmd/cdc/main.go 100.0000% <ø> (ø)
cdc/pkg/cmd/server/server.go 63.9751% <ø> (ø)
cdc/pkg/context/context.go 54.5454% <ø> (ø)
cdc/pkg/flags/urls.go 100.0000% <100.0000%> (ø)
cdc/pkg/httputil/httputil.go 90.4761% <100.0000%> (+5.8608%) ⬆️
cdc/pkg/regionspan/span.go 56.0975% <ø> (+5.1884%) ⬆️
cdc/pkg/util/ctx.go 76.4705% <100.0000%> (-12.1658%) ⬇️
... and 4 more

... and 20 files with indirect coverage changes

@pingyu pingyu changed the title [to: #366] *: Remove tidb dependency [to #323] *: Remove tidb dependency Nov 19, 2023
Signed-off-by: Ping Yu <[email protected]>
Copy link
Contributor

@zeminzhou zeminzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@pingyu pingyu merged commit 999ca43 into tikv:main Nov 20, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cdc: remove dependency of github.com/pingcap/tidb
2 participants