fix lint error

Signed-off-by: Ping Yu <[email protected]>
tikv · Dec 2, 2023 · 429254d · 429254d
1 parent 420a0bf
commit 429254d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/br/pkg/backup/client.go b/br/pkg/backup/client.go
@@ -250,7 +250,9 @@ func (bc *Client) BackupRanges(
 	progressCallBack func(ProgressUnit),
 ) error {
 	init := time.Now()
-	defer log.Info("Backup Ranges", zap.Duration("take", time.Since(init)))
+	defer func() {
+		log.Info("Backup Ranges", zap.Duration("take", time.Since(init)))
+	}()
 
 	if span := opentracing.SpanFromContext(ctx); span != nil && span.Tracer() != nil {
 		span1 := span.Tracer().StartSpan("Client.BackupRanges", opentracing.ChildOf(span.Context()))

diff --git a/br/pkg/backup/client_test.go b/br/pkg/backup/client_test.go
@@ -9,7 +9,7 @@ import (
 	"time"
 
 	"github.com/jarcoal/httpmock"
-	. "github.com/pingcap/check"
+	. "github.com/pingcap/check" // nolint:revive
 	backuppb "github.com/pingcap/kvproto/pkg/brpb"
 	"github.com/pingcap/kvproto/pkg/errorpb"
 	"github.com/pingcap/kvproto/pkg/kvrpcpb"

diff --git a/br/pkg/storage/s3_test.go b/br/pkg/storage/s3_test.go
@@ -21,7 +21,7 @@ import (
 	backuppb "github.com/pingcap/kvproto/pkg/brpb"
 	"github.com/stretchr/testify/require"
 	"github.com/tikv/migration/br/pkg/mock"
-	. "github.com/tikv/migration/br/pkg/storage"
+	. "github.com/tikv/migration/br/pkg/storage" // nolint:revive
 )
 
 type s3Suite struct {