Add methods taking file descriptor as OwnedFd. #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OwnedFd type confers ownership of the file descriptor, so these can be safe methods rather than relying on the caller not to use the file descriptor anywhere else after making the call. Signed-off-by: Andrew Walbran <[email protected]>
BusyJay
approved these changes
Nov 30, 2023
|
Thanks for the review! Can you merge the PR too? The CI failures are all existing issues as far as I can see, not changed by this PR. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
OwnedFdtype confers ownership of the file descriptor, so these can be safe methods rather than relying on the caller not to use the file descriptor anywhere else after making the call.