logger: fix file open issue if crypto algorithm is disabled #857
Conversation
jnippula
force-pushed
the
fix-logger-no-crypto
branch
from
9188888 to
b0a780b
Compare
|
Right, it was a bit confusing where and when the file is opened and how. Original idea was to create file already in init_logfile_encryption() even there is no key data (no_crypto) and then start_log would any case open file as append. Anyway, I made it now a bit different way: init_logfile_encryption() now gets keydata/keydatasize as param, allocate memory and store keydata there. Later the LogFileBuffer::start_log() gets the keydata buffer and if any data exists, it stores the keydata into the beginning of the recently opened file. How that looks? |
Store keydata into memory buffer in init phase. If keydata exists, write it into the beginning of the file when file is opened in LogFileBuffer::start_log()
jnippula
force-pushed
the
fix-logger-no-crypto
branch
from
b0a780b to
eb54001
Compare
| return; | ||
| } | ||
|
|
||
| #endif |
There was a problem hiding this comment.
I was just wondering; would it simply work if you pushed the keydata into buffer right after start_log here? That is,
_buffers[(int)type].write_no_check(keydata, keydatasize);
?
Then you didn't need to pass the keydata down to the start_log, or modify that?
Just an idea, I don't know if it would work or not ;)
There was a problem hiding this comment.
Ah.. sorry, now I understood what did you mean. That would be much much better! I'll check if that works.
Create empty file even if crypto key is not stored into the beginning of the log file to allow file logger to always append log data into existing file.