-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orb poll hrt #713
Orb poll hrt #713
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, seems like there is some unrelated HITL stuff here as well, fine by me tbh
Thanks for checking it out! This is still WIP, there is some instability when stopping mavlink. I will also change at least the following:
This is now an initial version to check the performance (which improves already significantly). When complete, I will mark it as ready for review, but any comments are of course welcome! |
I still removed the orb polling change from this PR; it is no longer related and better not to introduce other changes than this mavlink poll |
Now tested on desk and ready. A bit hard to review as most of stuff is reverts, better to just check the actual implementation commits |
I just realised a bug in the code; the interval of -1 (unlimited) is not handled. I need to revisit the code to manage that. Also there are couple of unused functions. |
a06d69b
to
36f15c4
Compare
Sleeping depends on the systick, which prevents using slower than 1ms systicks. Using HRT provides as performant way of handling the mavlink polling and is also more accurate. Co-authored-by: Jari Nippula <[email protected]> Signed-off-by: Jukka Laitinen <[email protected]>
Only use the needed HRT intervals, i.e. the shortest one by which all the other ones are evenly divisible with. Signed-off-by: Jukka Laitinen <[email protected]>
Replace orb polling with much simpler way to trigger periodic updates with HRT and wakeup the mavlink using HRT timer.