Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bson test for kernel-mode build #697

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

jnippula
Copy link

@jnippula jnippula commented May 17, 2024

Remove bson test from kernel-mode build.
Tinybson lib is located in kernel space and can't be accessed from user side tests app

Removal can be selected with config flag CONFIG_TESTS_KERNEL_MODE_COMPATIBLE
to separate it out from kernel-mode builds only

@jnippula jnippula requested a review from jlaitine May 17, 2024 13:06
@jnippula
Copy link
Author

Config flag can be removed if/when bson test is fixed somehow.

@jnippula jnippula requested a review from t-salminen May 17, 2024 13:10
Copy link

@jlaitine jlaitine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe unnecessary to add a flag for it, just disable in kernel mode build. This can then be reverted if it is fixed for kernel mode

@jnippula
Copy link
Author

jnippula commented May 20, 2024

Maybe unnecessary to add a flag for it, just disable in kernel mode build. This can then be reverted if it is fixed for kernel mode

Ok, I'll change the config flag with "if flat_build" check.

@jnippula jnippula force-pushed the tests-for-kernel-mode branch from 830d258 to 545f6c9 Compare May 20, 2024 06:53
@jnippula
Copy link
Author

Updated to build test_bson only for flat build

@jnippula jnippula requested review from jlaitine and t-salminen May 20, 2024 06:54
@jnippula jnippula merged commit 795fad9 into main May 20, 2024
28 checks passed
@jnippula jnippula deleted the tests-for-kernel-mode branch June 6, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants