Improve uorb subscription interval handling #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tervals Set the last_update to now-interval, instead of 0. Signed-off-by: Jukka Laitinen <[email protected]>
jlaitine
force-pushed
the
improve_uorb_subscription_interval_handling
branch
from
4839dc7 to
66546c4
Compare
pussuw
approved these changes
Feb 22, 2024
TimoSairiala
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue found with "topic_listener -r 1" command;
The topic which is subscribed with a rate of 1 second is initially given twice, and after that every 1 second.
The time when the topic was last updated can't be initialized to 0. The best possible initial value is "now - interval", which gives the subscriber the first publish after subscription, and after that according to the interval.