Add CRC code to EEPROM parameter storage #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jukka Laitinen <[email protected]>
jlaitine
force-pushed
the
params_debug
branch
from
77d5e21 to
af3949a
Compare
jlaitine
force-pushed
the
params_debug
branch
from
af3949a to
1ef0aa3
Compare
|
I added code to fill the block with ff and re-calculate the crc, if the block reading fails many times. If the content of the eeprom is corrupted, and the crc really doesn't match, the block is otherwise permanently unusable; when separate bytes are updated via MTD layer, the layer does read-modify-write for the block. If the block read fails permanently, it also cannot be written. |
jlaitine
force-pushed
the
params_debug
branch
from
1ef0aa3 to
2646fc9
Compare
|
Still fixed pixhawk build |
pussuw
approved these changes
Jan 18, 2024
An EEPROM behind and i2c media is not 100% failure proof. But any errors in e.g. mtd_params reading can cause catastrophic failures in flight. Mitigate any possible errors in px4 mtd_params reading by adding crc code to every page on EEPROM In addition: - Read every block into a temporary buffer before copying to clients buffer; this fixes some issues with memory protected builds when writing directly to user buffers from i2c driver interrupt handler - If a read request fails, don't return any partially filled buffer to user Signed-off-by: Jukka Laitinen <[email protected]>
jlaitine
force-pushed
the
params_debug
branch
from
2646fc9 to
95f1601
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.