New dataman #577
Merged
New dataman #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, lets first test the PR output separately before merging though |
jlaitine
approved these changes
Dec 7, 2023
…erate function Signed-off-by: Silvan Fuhrer <[email protected]>
Signed-off-by: Silvan Fuhrer <[email protected]>
Signed-off-by: Silvan Fuhrer <[email protected]>
clear dataman file and init initial value on creation
Rework of dataman
A version update is needed since the dataman is showing errors if data doesn't exist or if it is wrongly stored. This will force default data to be initialized.
tests dataman will trigger errors and run_nsh_cmd.py is not written to detect only when a test fails. This is properly tested with run_tests.py
…anges This avoids the need to regularly access dataman for checking.
Avoids unnecessary dataman accesses
…dataman' As this test is expected to contain errors.
This can happen e.g. when the item is cleared.
Instead of also when geofence/safe points updated. This prevents reporting multiple times.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport new dataman implementation, which is compatible with kernel mode as-is