platforms/common/uORB/uORBDeviceNode: Make consistent use of ATOMIC_ENTER #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_LEAVE macros These macros were only used to protect write / copy functions. Use them also for callback registration. Signed-off-by: Jukka Laitinen <[email protected]>
jlaitine
force-pushed
the
uorb_sem_fix
branch
from
a953c49 to
23d876e
Compare
pussuw
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just changing things that looked odd to me.
ATOMIC_ENTER / ATOMIC_LEAVE should probably be used consistently; In flat build use the critical_section in all places, just like in protected builds it uses the semaphore.