Fix clock realtime monotonic #574
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LTIME -> CLOCK_MONOTONIC in SITL" This reverts commit 556c3a3.
…ONOTONIC Signed-off-by: Jukka Laitinen <[email protected]>
Signed-off-by: Jukka Laitinen <[email protected]>
This is a fix for: 73cda71 Author: Jukka Laitinen <[email protected]> Date: Wed Apr 27 10:55:23 2022 +0400 Change orb_publish interface and intialization of advertiser handles Signed-off-by: Jukka Laitinen <[email protected]>
Signed-off-by: Jukka Laitinen <[email protected]>
jlaitine
commented
Dec 1, 2023
| int take_timedwait(struct timespec *abstime) | ||
| { | ||
| #if defined(CONFIG_ARCH_BOARD_PX4_SITL) | ||
| return px4_sem_timedwait(&_sem, abstime); |
There was a problem hiding this comment.
This is not 100% right, but needed for SITL because of lockstep scheduler. px4_sem_timedwait acts as a wrapper around that as well.
pussuw
reviewed
Dec 1, 2023
| #if defined(CONFIG_ARCH_BOARD_PX4_SITL) | ||
| return px4_sem_timedwait(&_sem, abstime); | ||
| #else | ||
| return sem_clockwait(&_sem, CLOCK_MONOTONIC, abstime); |
There was a problem hiding this comment.
yes, could introduce that. might reduce confusion...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the use of CLOCK_REALTIME -> CLOCK_MONOTONIC in a couple of places
This PR includes one extra patch for fixing buiding one SITL/Test file.