Add version messages #555
Add version messages #555
Conversation
These can be used to transfer version information accross the system (ver, mavlink...) without link dependency to version libraries Also this allows easy publishing the autopilot versions to ROS2 over uXRCE-DDS Signed-off-by: Jukka Laitinen <[email protected]>
|
|
||
| /* Bootloader version */ | ||
|
|
||
| strncpy(ver_str.bl_version, device_boot_info.bl_version, sizeof(ver_str.os_version)); |
There was a problem hiding this comment.
Is here copy paste error ? sizeof ver_str.os_version should be ver_str.bl_version ?
There was a problem hiding this comment.
Yes! Very much so need to fix that.
I was also wondering if it makes more sense to better align with formats in src/lib/version/version.c , and not to invent an own encoding scheme for the binary format things. And maybe move the publishing directly in there as well. I will move this to Draft for now, and try out some different things first, and not jump directly in merging this one.
There was a problem hiding this comment.
Tried to move the publishing to common code; but versions related code is so messed up that it doesn't make sense to try to improve it really.
This is good for us, so let's just keep it the way it is.
Signed-off-by: Jukka Laitinen <[email protected]>
Signed-off-by: Jukka Laitinen <[email protected]>
jlaitine
force-pushed
the
add_version_messages
branch
from
95a417a to
125ef12
Compare
This adds version information into uORB topics, allowing easy version information pulishing to ROS (uXRCE) and access from applications in memory protected build modes of PX4