Clean up saluki submodule #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaitine
force-pushed
the
clean_up_saluki_submodule
branch
from
9a19f3a to
2fb7832
Compare
|
This structure doesn't work out in practice, submodule structure still needs to be flattened. |
jlaitine
force-pushed
the
clean_up_saluki_submodule
branch
2 times, most recently
from
3d88be5 to
dafd02d
Compare
Signed-off-by: Jukka Laitinen <[email protected]>
Signed-off-by: Jukka Laitinen <[email protected]>
Signed-off-by: Jukka Laitinen <[email protected]>
jlaitine
force-pushed
the
clean_up_saluki_submodule
branch
from
dafd02d to
24479d3
Compare
|
Note: coverity scan test failing is not due to this PR, I managed to screw up the coverity scan server with clever submodule updates earlier ;) |
t-salminen
approved these changes
Nov 9, 2023
pussuw
approved these changes
Nov 9, 2023
|
I am pushing in the submodule changes and this PR; seems to be working ok. Will do the same chages to v1.13.3-fc-only branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.