Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel mavlink logging for LMC #525

Merged
merged 8 commits into from
Oct 25, 2023
Merged

Conversation

jnippula
Copy link

Flight logging via Mavlink changes to transfer static definitions in parallel with topic data to avoid several seconds long blackout period in the beginning of the log.
This requires PARALLEL_LOGGING support also from receiver end (e.g. mavlink-router).

@jnippula jnippula force-pushed the rebase-parallel_logging branch 2 times, most recently from 190ad6f to 9f6647c Compare October 18, 2023 13:21
Copy link

@maseabunikie maseabunikie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Special mention goes to this document: src/modules/logger/parallel_mavlink_logging.md.
Very good!!!

Copy link

@jlaitine jlaitine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only question I have is, if we truly need another linked list implementation embedded in here; I didn't deep dive into it just looks peculiar as there are plenty of implementations already all around px4....

@jnippula
Copy link
Author

LGTM, only question I have is, if we truly need another linked list implementation embedded in here; I didn't deep dive into it just looks peculiar as there are plenty of implementations already all around px4....

That is a valid point. Need to check if there is any common impl available to use for that.

@jnippula jnippula force-pushed the rebase-parallel_logging branch 2 times, most recently from c5002a1 to ac8a021 Compare October 23, 2023 13:16
@jnippula
Copy link
Author

jnippula commented Oct 23, 2023

Re-used linked list implementation from src/include/containers/List.hpp. Looks a bit smoother now.
Functionality verified with SingleSocSaluki HITL env

@jnippula jnippula requested a review from jlaitine October 23, 2023 13:18
@jlaitine jlaitine force-pushed the main_rebase branch 2 times, most recently from 6205b89 to 1fb1bef Compare October 25, 2023 11:22
@jnippula jnippula force-pushed the rebase-parallel_logging branch from ac8a021 to 2f9d8dc Compare October 25, 2023 12:27
@jnippula
Copy link
Author

Rebased again due to the main_rebase updated from upstream.

@jnippula jnippula merged this pull request into main_rebase Oct 25, 2023
3 checks passed
@jnippula jnippula deleted the rebase-parallel_logging branch June 6, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants