-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallel mavlink logging for LMC #525
Conversation
190ad6f
to
9f6647c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Special mention goes to this document: src/modules/logger/parallel_mavlink_logging.md.
Very good!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only question I have is, if we truly need another linked list implementation embedded in here; I didn't deep dive into it just looks peculiar as there are plenty of implementations already all around px4....
That is a valid point. Need to check if there is any common impl available to use for that. |
c5002a1
to
ac8a021
Compare
Re-used linked list implementation from src/include/containers/List.hpp. Looks a bit smoother now. |
6205b89
to
1fb1bef
Compare
ac8a021
to
2f9d8dc
Compare
Rebased again due to the main_rebase updated from upstream. |
Flight logging via Mavlink changes to transfer static definitions in parallel with topic data to avoid several seconds long blackout period in the beginning of the log.
This requires PARALLEL_LOGGING support also from receiver end (e.g. mavlink-router).