Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

px4_sem_init: Disable priority inheritance for signaling semaphores #515

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

pussuw
Copy link

@pussuw pussuw commented Oct 5, 2023

No description provided.

pussuw added 2 commits October 5, 2023 14:39
The head/tail semaphores are not used as lock but rather as resource
counters and thus relate more as signaling semaphores. Disable PI for
them.

I run my code with CONFIG_DEBUG_ASSERTIONS=y and the kernel panics due
to the semaphore having no holder, disabling PI fixes this.
WorkItemSingleShot::_sem is a signaling semaphore, disable PI for it.

Set CONFIG_DEBUG_ASSERTIONS=y and the kernel panics due to the semaphore
having no holder, disabling PI fixes this.
@pussuw pussuw requested a review from jlaitine October 5, 2023 11:45
@pussuw pussuw changed the title Pi disable signalsem px4_sem_init: Disable priority inheritance for signaling semaphores Oct 5, 2023
Copy link

@jlaitine jlaitine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be upstreamed most likely(?)

@pussuw
Copy link
Author

pussuw commented Oct 6, 2023

Yes I was planning to do that

@pussuw pussuw merged commit f7a78e0 into main Oct 6, 2023
21 checks passed
@pussuw pussuw deleted the pi_disable_signalsem branch October 6, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants