fs/shm/shmfs_alloc.c: Allocate zero-initialized memory in flat build #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will put the same suggestion to upstream as well. |
jlaitine
force-pushed
the
fix_shm_to_allocate_zero_initialized_memory
branch
2 times, most recently
from
52dd9d0 to
7631f45
Compare
pussuw
approved these changes
Dec 12, 2024
|
Cleaned it up acc. to the comments... |
POSIX requires that the shm objects are zero-initialized. This has been broken in some earlier commits (starting from 9af5fc5) Also fix the flat build memory allocation to allocate both object data and payload in the same chunk (as the comment also suggests). This saves allocations and memory in a system with lots of shm objects. Signed-off-by: Jukka Laitinen <[email protected]>
jlaitine
force-pushed
the
fix_shm_to_allocate_zero_initialized_memory
branch
from
7631f45 to
7b1babf
Compare
|
And fixed also protected build branch... |
pussuw
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POSIX requires that the shm objects are zero-initialized. This has been broken in some earlier commits (starting from 9af5fc5)
Also fix the flat build memory allocation to allocate both object data and payload in the same chunk (as the comment also suggests). This saves allocations and memory in a system with lots of shm objects.