drivers/tca64xx: Add support for PCAL6416 #312
Conversation
| if ((direction == IOEXPANDER_DIRECTION_IN_PULLDOWN) || | ||
| (direction == IOEXPANDER_DIRECTION_IN_PULLUP)) | ||
| { | ||
| regaddr = tca64_pdenable_reg(priv, pin); |
There was a problem hiding this comment.
There is no error handling now if PU/PD setting is attempted for other parts than the one which has the register. You should propably add "define TCA6424_INVALID_REG 0xff" or such in header, and make tca64_pdenable_reg return that if part->tp_pu_select is 0.
Then you can check the regaddr here (!= TCA6424_INVALID_REG) and bail out if the part doesn't support PU/PD....
joukkone
force-pushed
the
pcal6416
branch
2 times, most recently
from
7b1f88b to
1ec4ea4
Compare
drivers/ioexpander/tca64xx.c
Outdated
| FAR const struct tca64_part_s *part = tca64_getpart(priv); | ||
| uint8_t reg = part->tp_puenable; | ||
|
|
||
| if (reg == TC64XX_INVALID_REG) |
There was a problem hiding this comment.
If you do other way around;
if (reg === 0) return TC64XX_INVALID_REG;
This makes more sense. Now this returns 0, which is a valid register address.... even though never pdenable register.
or, if (reg == TC64XX_INVALID_REG) return reg;
drivers/ioexpander/tca64xx.c
Outdated
| FAR const struct tca64_part_s *part = tca64_getpart(priv); | ||
| uint8_t reg = part->tp_pu_select; | ||
|
|
||
| if (reg == TC64XX_INVALID_REG) |
drivers/ioexpander/tca64xx.c
Outdated
| (direction == IOEXPANDER_DIRECTION_IN_PULLUP)) | ||
| { | ||
| regaddr = tca64_pdenable_reg(priv, pin); | ||
| if (regaddr == 0) |
There was a problem hiding this comment.
And here if (regaddr == TC64XX_INVALID_REG) ....
|
What you did works; it is just a bit confusing because it returns regaddr, which is valid (0), and you just know that 0 cannot be right one. Rather return the invalid address all the way to the place where it is queried. |
New part support added to driver, pullup/pulldown configuration support Signed-off-by: Jouni Ukkonen <[email protected]>
New part support added to driver,
pullup/pulldown configuration support
Summary
Impact
Testing