Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To enable QoS-OLSR in MS2.0 #347

Merged
merged 4 commits into from
Dec 7, 2023
Merged

To enable QoS-OLSR in MS2.0 #347

merged 4 commits into from
Dec 7, 2023

Conversation

francislin12
Copy link
Contributor

The change can be summarized as below:

  1. Run Qos-Olsr on the mesh mode, having a function to start and stop QoS-OLSR
  2. Make it work on the IPV6

joenpera
joenpera requested changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@joenpera joenpera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR done to wrong branch.

@francislin12 francislin12 changed the base branch from main to develop November 29, 2023 17:17
TIISR
TIISR suggested changes Nov 30, 2023
View reviewed changes
common/scripts/qos_olsrd_conf.sh Outdated Show resolved Hide resolved
common/scripts/qos_olsrd_conf.sh Outdated Show resolved Hide resolved
common/scripts/qos_olsrd_conf.sh Outdated Show resolved Hide resolved
common/tests/functional/Test-throughput.sh Outdated Show resolved Hide resolved
common/tests/functional/Test-throughput.sh Outdated Show resolved Hide resolved
common/tests/functional/Test-throughput.sh Outdated Show resolved Hide resolved
common/tests/functional/Test-throughput.sh Show resolved Hide resolved
@joenpera
Copy link
Contributor

joenpera commented Nov 30, 2023 •
edited
Loading

Why github compare is showing these as new files? There is something wrong with the PR and real changes can't be compared and shown.

Please check that you had develop branch in use when making changes.

@mbaddeley
Copy link
Contributor

Why github compare is showing these as new files? There is something wrong with the PR and real changes can't be compared and shown.

Please check that you had develop branch in use when making changes.

It's coming up like this because @francislin12 branched off of main instead of develop. @francislin12 please apply these changes to develop instead, and then you will see it not coming up as a new file.

@mbaddeley
Copy link
Contributor

Rebased this commit on top of develop

TIISR
TIISR suggested changes Dec 6, 2023
View reviewed changes
common/scripts/qos_olsrd_conf.sh Outdated Show resolved Hide resolved
joenpera
joenpera requested changes Dec 7, 2023
View reviewed changes
common/scripts/mesh-11s_nats.sh Outdated Show resolved Hide resolved
joenpera
joenpera approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@joenpera joenpera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future improvement I propose to use daemon instead of start-stop-daemon as daemon can handle service respawn if service crashed.

TIISR
TIISR approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@TIISR TIISR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading in a hurry only but let's not block anymore :)

@TIISR TIISR merged commit 89ae77f into develop Dec 7, 2023
2 checks passed
@mbaddeley mbaddeley deleted the qos-nats-olsr branch December 7, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TIISR TIISR TIISR approved these changes

@joenpera joenpera joenpera approved these changes

@mbaddeley mbaddeley mbaddeley approved these changes

@govindsi govindsi Awaiting requested review from govindsi

@Monika-Research Monika-Research Awaiting requested review from Monika-Research

Assignees

@francislin12 francislin12

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@francislin12 @joenpera @mbaddeley @TIISR