Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pytorch package installation #334

Merged
merged 5 commits into from
Nov 17, 2023
Merged

Pytorch package installation #334

merged 5 commits into from
Nov 17, 2023

Conversation

dania-tii
Copy link
Collaborator

@dania-tii dania-tii commented Nov 15, 2023 •
edited
Loading

Installing torch-1.13.1

  • This package is required for jamming avoidance and LDPI (IDS)
  • It cannot be installed via buildroot as the source code is not available

joenpera
joenpera requested changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@joenpera joenpera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

includes only aarch64 installation packages.

@dania-tii
Copy link
Collaborator Author

dania-tii commented Nov 16, 2023 •
edited
Loading

includes only aarch64 installation packages.

I updated the code such that the installation of pytorch occurs for aarch64. The IDS and jamming avoidance features, which require the pytorch package, for now are intended to be enabled only for CM4 platform with aarch64.

@dania-tii dania-tii requested a review from joenpera November 16, 2023 14:18
@joenpera
Copy link
Contributor

joenpera commented Nov 17, 2023 •
edited
Loading

I was thinking that should we have this installation process before entrypoint_nats.sh is called and actually in mesh_start.sh? As now we are starting all processes and after that installing dependencies.

joenpera
joenpera requested changes Nov 17, 2023
View reviewed changes
Copy link
Contributor

@joenpera joenpera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same was added already as comment:
I was thinking that should we have this installation process before entrypoint_nats.sh is called and actually in mesh_start.sh? As now we are starting all processes and after that installing dependencies.

@dania-tii
Copy link
Collaborator Author

dania-tii commented Nov 17, 2023 •
edited
Loading

Same was added already as comment: I was thinking that should we have this installation process before entrypoint_nats.sh is called and actually in mesh_start.sh? As now we are starting all processes and after that installing dependencies.

ok, I'll open a pr to install the dependencies via mesh_start.sh, this pr will be to add ml_packages.tar.gz and the install_dependencies.sh script

@dania-tii dania-tii closed this Nov 17, 2023
@dania-tii dania-tii reopened this Nov 17, 2023
@dania-tii dania-tii requested a review from joenpera November 17, 2023 08:40
@martin-tii martin-tii merged commit b6841ec into develop Nov 17, 2023
2 checks passed
@dania-tii dania-tii deleted the torch_package branch December 5, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-tii martin-tii martin-tii approved these changes

@joenpera joenpera joenpera approved these changes

@govindsi govindsi Awaiting requested review from govindsi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dania-tii @joenpera @martin-tii