Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress generic-x86_64 image #937

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

remimimimimi
Copy link
Contributor

Description of changes

Checklist for things done

Binary images of all other targets are compressed already during the build phase. This makes downloads significantly faster. Compress also x86_64-linux.generic-x86_64-debug image in the build phase.

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

Check that image works as expected after manual decompression or check that flash script succeeds.

Signed-off-by: Valentin Kharin <[email protected]>
@remimimimimi remimimimimi temporarily deployed to internal-build-workflow December 18, 2024 11:46 — with GitHub Actions Inactive
@remimimimimi remimimimimi marked this pull request as ready for review December 18, 2024 13:10
@remimimimimi remimimimimi added the Needs Testing CI Team to pre-verify label Dec 18, 2024
@milva-unikie
Copy link

Tested on NUC (generic-x86_64-debug)

  • The size of the compressed image is 3,1 GB
  • When uncompressed the size is 13,3 GB
  • I built, flashed and booted, works great

This change will require changes to test-automation. Those will need to be prepared before this pr is merged. They are under work now.

I will add the bug-label here until the test-automation has been fixed to support this pr. We don't really have an accurate label for this situation.

@milva-unikie milva-unikie added bug Something isn't working Tested on NUC This PR has been tested on Intel NUC and removed Needs Testing CI Team to pre-verify labels Dec 19, 2024
@milva-unikie
Copy link

Test-automation has been checked and it works with this pr. This can now be merged.

@milva-unikie milva-unikie removed the bug Something isn't working label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tested on NUC This PR has been tested on Intel NUC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants