Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable nix tooling #930

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

gngram
Copy link
Contributor

@gngram gngram commented Dec 11, 2024

Description of changes

  • Disables nix tooling if development setup is not enabled
    - Indirectly disables nix tooling in release build
  • Enables automatic garbaze collection in ghaf-host and disable everywhere else.
  • Fixes:
    https://jira.tii.ae/browse/SSRCSP-3457

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to:
    • Lenovo X1
    • Jetson Orin NX and AGX
  • Is this a new feature
    • List the test steps to verify:
      • In release build, no nix commands should be available, nix daemon should not be running
      • In debug build nix daemon should be running in all VMs and automatic garbaze collection should be available only in host.
      • If automatic garbaze collection is enabled 'systemctl list-timers' should list 'nix-gc' also
  • If it is an improvement how does it impact existing functionality?

@gngram gngram temporarily deployed to internal-build-workflow December 11, 2024 07:25 — with GitHub Actions Inactive
@@ -18,37 +19,49 @@ in
default = null;
description = "Path to the nixpkgs repository";
};
automatic-gc = {
enable = mkEnableOption "Enable automatic garbaze collection";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grabage?

@gngram gngram force-pushed the pr__disable_nix_tooling branch from 3045be2 to 1413eb9 Compare December 11, 2024 09:26
@gngram gngram temporarily deployed to internal-build-workflow December 11, 2024 09:26 — with GitHub Actions Inactive
- Disable nix tooling if development setup is not enabled
- Indirectly disables nix tooling in release build
- Enable automatic garbage collection in ghaf-host only

Signed-off-by: Ganga Ram <[email protected]>
@gngram gngram force-pushed the pr__disable_nix_tooling branch from 1413eb9 to 8dac282 Compare December 17, 2024 11:37
@gngram gngram temporarily deployed to internal-build-workflow December 17, 2024 11:37 — with GitHub Actions Inactive
};
})

(mkIf (!cfg.enable) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe better to avoid using mkForce, set these options above? So nix.enable = cfg.enable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants