Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ctrl panel bug report #926

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

Nerox9
Copy link
Contributor

@Nerox9 Nerox9 commented Dec 10, 2024

Description of changes

MAC address shared with GUIVM.
Report page is added into settings of control panel.
Github configuration is added to submit a report. It has to be updated with valid info.
Bug report icon is not provided.

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to:
    • Lenovo X1 x86_64
  • Is this a new feature
    • List the test steps to verify:
      • Build with your github configuration from modules/reference/profiles/laptop-x86.nix (Optionally ~/.config/ctrl-panel/config.toml file can be edited after build).
      • Run ghaf and launch the control panel.
      • Click to settings and select the report page from the bottom of the list.
      • Fill the report and submit. It prompts fail messages when any question is not answered or github configuration is not working.
  • If it is an improvement how does it impact existing functionality?

@Nerox9 Nerox9 temporarily deployed to internal-build-workflow December 10, 2024 09:11 — with GitHub Actions Inactive
@Nerox9 Nerox9 requested a review from dmitry-erin December 10, 2024 09:11
@Nerox9 Nerox9 marked this pull request as draft December 10, 2024 09:11
@Nerox9 Nerox9 temporarily deployed to internal-build-workflow December 10, 2024 09:14 — with GitHub Actions Inactive
@Nerox9 Nerox9 temporarily deployed to internal-build-workflow December 11, 2024 14:05 — with GitHub Actions Inactive
@Nerox9 Nerox9 temporarily deployed to internal-build-workflow December 11, 2024 14:52 — with GitHub Actions Inactive
@Nerox9 Nerox9 changed the title Ctrl panel report Ctrl panel bug report Dec 11, 2024
@Nerox9 Nerox9 temporarily deployed to internal-build-workflow December 11, 2024 21:17 — with GitHub Actions Inactive
@Nerox9 Nerox9 marked this pull request as ready for review December 11, 2024 21:28
@Nerox9 Nerox9 requested review from nesteroff and vadika December 11, 2024 21:29
@Nerox9 Nerox9 marked this pull request as draft December 11, 2024 21:47
@Nerox9 Nerox9 temporarily deployed to internal-build-workflow December 12, 2024 09:09 — with GitHub Actions Inactive
@Nerox9 Nerox9 marked this pull request as ready for review December 12, 2024 09:09
@Nerox9 Nerox9 added the Needs Testing CI Team to pre-verify label Dec 12, 2024
@Nerox9 Nerox9 temporarily deployed to internal-build-workflow December 12, 2024 10:39 — with GitHub Actions Inactive
@milva-unikie milva-unikie removed the Needs Testing CI Team to pre-verify label Dec 12, 2024
@Nerox9 Nerox9 temporarily deployed to internal-build-workflow December 13, 2024 10:43 — with GitHub Actions Inactive
@Nerox9 Nerox9 requested a review from nesteroff December 13, 2024 10:46
@Nerox9 Nerox9 temporarily deployed to internal-build-workflow December 13, 2024 11:14 — with GitHub Actions Inactive
Add report page into control panel

MAC address shared with GUIVM
Report page is added into settings of control panel
Github configuration is added to submit a report

Signed-off-by: Berk Arslan <[email protected]>
@Nerox9 Nerox9 temporarily deployed to internal-build-workflow December 13, 2024 11:28 — with GitHub Actions Inactive
@Nerox9 Nerox9 added the Needs Testing CI Team to pre-verify label Dec 13, 2024
@milva-unikie
Copy link

Tested on Lenovo-X1 (nixos-rebuild switch)

There is a few issues with this. We discussed those with Berk, this comment is mostly a summary.

  • Token to the Ghaf repo should be added so that the reports are automatically sent to the issues here.
  • App list should be updated according to the current apps.
  • Add a field for a title of the issue and use that when opening an issue in Git.
  • It would be nice for the text fields to expand with long text. Now it only scrolls sideways. Especially annoying when describing the issue.
  • The contrast is not good, but this is a wider problem with the control panel.

@milva-unikie milva-unikie added bug on Lenovo X1 Carbon Issues found on Lenovo X1 Carbon while checking this PR and removed Needs Testing CI Team to pre-verify labels Dec 17, 2024
@Nerox9 Nerox9 added Needs Testing CI Team to pre-verify bug on Lenovo X1 Carbon Issues found on Lenovo X1 Carbon while checking this PR and removed bug on Lenovo X1 Carbon Issues found on Lenovo X1 Carbon while checking this PR Needs Testing CI Team to pre-verify labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug on Lenovo X1 Carbon Issues found on Lenovo X1 Carbon while checking this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants