Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build.yml: Use nix-fast-build to build on remote #874

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

henrirosten
Copy link
Collaborator

Description of changes

Start using nix-fast-build in the build.yml workflow to execute all build operations completely on the remote end.

Removes the step 'Maximize space available on rootfs' since with nix-fast-build, we no longer download the full build closure on the github-hosted runner. Furthermore, with the --no-download option, we also skip the download of the final build result (ghaf image), so we no longer need to free up the storage on the github runner.

This change also removes the upload to https://ghaf-dev.cachix.org from the build workflow: it is no longer needed, since builds are already cached on the remote builders' local nix store. Jenkins builds will take care of uploading the build binaries to a separate nix binary cache, maintained with ghaf-infra.

With the above summarized changes, build times on the build.yml workflow will significantly reduce. It should also completely remove the hash mismatch issues on the build workflow as builds and also evaluation operations are executed on the remote.

This change was tested on a fork, as an example, see: https://github.com/henrirosten/ghaf/actions/runs/11587433044.

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to:
  • Is this a new feature
    • List the test steps to verify:
  • If it is an improvement how does it impact existing functionality?

@henrirosten henrirosten marked this pull request as ready for review October 30, 2024 05:57
@henrirosten henrirosten had a problem deploying to internal-build-workflow October 30, 2024 06:04 — with GitHub Actions Error
@brianmcgillion brianmcgillion merged commit 147f806 into main Oct 30, 2024
5 of 8 checks passed
@brianmcgillion brianmcgillion deleted the build-workflow-use-nix-fast-build branch October 30, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants