build.yml: Build x86 generic and x1 targets #866
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Start building ghaf targets
generic-x86_64-debug
andlenovo-x1-carbon-gen11-debug
in the build.yml workflow.This should work after #865 since all the builds are now done on the remote builders, not on the github-hosted runners. Earlier attempts to enable
generic-x86_64-debug
orlenovo-x1-carbon-gen11-debug
on the build workflow have failed due to two reasons: (1) github-hosted runners not having enough resources to build these massive targets and (2) hash mismatches I suspect have occurred mostly due to github-hosted runners running the builds on Ubuntu-based VMs. After #865, both those issues should be resolved by running all the builds on the remote (nix) builders.Depends-on: #865: Do not merge before #865 is merged.
This change was tested in a fork at: https://github.com/henrirosten/ghaf. Especially, see the
generic-x86_64-debug
andlenovo-x1-carbon-gen11-debug
builds on the following test PRs:Checklist for things done
x86_64
aarch64
riscv64
make-checks
and it passesnixos-rebuild ... switch
Instructions for Testing