Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fprint: Add terminal based app for finger print. #842

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fprint: Add terminal based app for finger print. #842

wants to merge 1 commit into from
+90 −0

Conversation

vunnyso
Copy link
Contributor

@vunnyso vunnyso commented Oct 10, 2024 •
edited
Loading

Description of changes

  • For user finger print enrollment add terminal based app which will take finger input to enroll finger based authenication in the system.
  • Works fine across system reboot as well.

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to:
  • Is this a new feature
    • List the test steps to verify:
  • If it is an improvement how does it impact existing functionality?

Functionality

image

@vunnyso
fprint: Add terminal based app for finger print.
b5447e5 
For user finger print enrollment add terminal based
app which will take finger input to enroll finger based
authenication in the system.
Works fine across system reboot as well.

Signed-off-by: Vunny Sodhi <[email protected]>
@vunnyso vunnyso temporarily deployed to internal-build-workflow October 10, 2024 14:05 — with GitHub Actions Inactive
@vunnyso vunnyso marked this pull request as draft October 11, 2024 06:52
@vunnyso
Copy link
Contributor Author

vunnyso commented Oct 11, 2024

@dmitry-erin can we integrate finger print authentication with Control panel?
Reference could be Ubuntu

@dmitry-erin
Copy link
Contributor

@dmitry-erin can we integrate finger print authentication with Control panel? Reference could be Ubuntu

From UI side I don't see any obstacles. What are the requirements for this? Authentication for getting access to what?

@vunnyso
Copy link
Contributor Author

vunnyso commented Oct 11, 2024

@dmitry-erin can we integrate finger print authentication with Control panel? Reference could be Ubuntu

From UI side I don't see any obstacles. What are the requirements for this? Authentication for getting access to what?

Great, we have fprintd-enroll already working as command line. We want to integrate that in UI, so that user can enroll their finger and login using fingerprint instead of typing password when system is locked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianmcgillion brianmcgillion Awaiting requested review from brianmcgillion

@humaidq-tii humaidq-tii Awaiting requested review from humaidq-tii

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vunnyso @dmitry-erin