Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FEH gtk-based light image viewer to ZaturaVM #826

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vadika
Copy link
Contributor

@vadika vadika commented Oct 7, 2024

Description of changes

Added FEH gtk-based light-footprint image viewer to ZaturaVM.
XDG handlers are coming in separate commit.

Checklist for things done

  • [X ] Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to:
  • Is this a new feature
    • List the test steps to verify:
  • If it is an improvement how does it impact existing functionality?

@vadika vadika temporarily deployed to internal-build-workflow October 7, 2024 12:17 — with GitHub Actions Inactive
@vadika vadika requested a review from brianmcgillion October 7, 2024 12:17
@vadika vadika added the Needs Testing CI Team to pre-verify label Oct 7, 2024
@vadika vadika mentioned this pull request Oct 7, 2024
19 tasks
@humaidq-tii
Copy link
Member

If the goal is to run the image viewer on zathura-vm, then there should be some automatic copy mechanism when someone opens an image on other VMs.

Because currently, zathura-vm doesn't use storagevm mounts.

@milva-unikie
Copy link

Before the XDG handlers are added I don't think it makes sense to add this. Tested on Lenovo-X1 that there is now Image Viewer icon, but it does not open the app. Is the icon is even going to be needed if the images are supposed to open automatically in the app?

@milva-unikie milva-unikie removed the Needs Testing CI Team to pre-verify label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants