Pin nixos-anywhere, fix README #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pin nixos-anywhere to prevent possible issues caused by upstream PR: nix-community/nixos-anywhere#243. Read more from the below nixpkgs issue: NixOS/nixpkgs#265014. - Fix the task.py usage instructions in README.md after #8. - Make `nix flake check` pre-push check less verbose. Signed-off-by: Henri Rosten <[email protected]>
|
Usually changes unrelated to each other should not go to the same commit (they can be in the same PR), but I'm not requesting splitting this commit now that it would take some effort. Just a note for the future. |
joinemm
approved these changes
Nov 6, 2023
I agree, but we are still far from production (or using this tooling anywhere for that matter), so I think it's fine for now until we declare it's not :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*** buffer overflow detected ***: terminatedNixOS/nixpkgs#265014.nix flake checkpre-push check less verbose.